chore: upgrade tachometer #4440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Aug 5, 2024
| "jsonwebtoken": "Pinned to address security vulnerability", | ||
| "semver": "Pinned to address security vulnerability", | ||
| "systeminformation": "Pinned to address security vulnerability" | ||
| "semver": "Pinned to address security vulnerability" | ||
| }, | ||
| "http-cache-semantics": "4.1.1", |
There was a problem hiding this comment.
Still needed for karma-sauce-launcher-fix-firefox; I will push a new version of that and then we can get rid of this.
There was a problem hiding this comment.
Actually, that's more trouble than it's worth. We should just move off of Karma eventually anyway.
wjhsf
approved these changes
Aug 5, 2024
| # This is bizarre, but it seems to be the only way to get Tachometer to recognize | ||
| # our local deps, e.g. when running in `this-patch` mode (not `tip-of-tree` mode). | ||
| # See: https://github.com/Polymer/tachometer/issues/215 | ||
| # This is a bit bizarre, but it's very tricky to get Tachometer to allow bare npm-style imports in |
There was a problem hiding this comment.
Glad to see this PR reducing the the bizarrosity of the code base!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I realized I can upgrade Tachometer since I had just missed that we need the
"root"property to make bare npm imports work properly: google/tachometer#244 (comment)Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?