Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update prettier to v3 #4443

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Aug 6, 2024

Details

Some snapshots had to be updated. See: prettier/prettier#9559 prettier/prettier#15835

Removed @types/prettier dependency (deprecated) as prettier v3 provides its own type definitions.

Closes #4386

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

Copy link
Contributor

@wjhsf wjhsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta run prettier on the code base. 🫠 Please update the prettierrc to minimize the diff, if there's any config that can be updated.

Also, just for the GitHub auto magic, this closes #4386, not #4384.

@nolanlawson
Copy link
Collaborator

/nucleus test

Copy link
Contributor

Well that's strange! A workflow could not be found for this PR. Please try running the /nucleus start command to start the workflow.

@nolanlawson
Copy link
Collaborator

/nucleus start

@nolanlawson nolanlawson merged commit cdb169a into salesforce:master Aug 7, 2024
11 checks passed
@nolanlawson
Copy link
Collaborator

Thanks a bunch! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to prettier v3
3 participants