chore: restore release:version script
#4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Unfortunately, it turns out that #4445 regressed the
release:versionscript. It no longer updates the version in the root (monorepo)package.json, and more importantly, doesn't bump the versions in private packages like@lwc/integration-tests. I opened a discussion on NX about this: nrwl/nx#27566In the meantime, we should revert to the old
release:versionscript. Otherwise our tests will be running against old versions pulled from npm rather than the local versions of the code!Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?