Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nucleus): remove downstreams that always fail #4509

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Aug 30, 2024

Details

In #4508, nucleus failed for three downstream projects due to the v7 type changes. Two of them are unlikely to be fixed, so let's just remove them.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner August 30, 2024 19:15
@wjhsf wjhsf enabled auto-merge (squash) August 30, 2024 19:20
@wjhsf wjhsf changed the title chore(nucleus): remove unmaintained downstreams that always fail chore(nucleus): remove downstreams that always fail Aug 30, 2024
@wjhsf wjhsf merged commit a7c6e78 into master Aug 30, 2024
11 checks passed
@wjhsf wjhsf deleted the wjh/trim-nucleus-downstreams branch August 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants