fix(engine): avoid non-string scope tokens #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 3, 2024
| 'stylesheets', | ||
| 'renderMode', | ||
| 'legacyStylesheetToken', | ||
| ] as const; |
There was a problem hiding this comment.
This just adds a warning in dev mode for setting legacyStylesheetToken, which we may as well do since it makes the test more consistent.
nolanlawson
changed the title
jye-sf
approved these changes
Sep 3, 2024
nolanlawson
added a commit
that referenced
this pull request
Sep 5, 2024
nolanlawson
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes validation of attribute names / static content HTML for dynamically-set stylesheet tokens.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Setting
template.stylesheetTokennow requires a string value.GUS work item
W-16614556