feat: simplify-log-colorization #484
Conversation
| } | ||
| } | ||
|
|
||
| const formatForTable = (logRecord: LogRecord): LogForTable => ({ |
There was a problem hiding this comment.
there's really only 2 fields that needed transorming. The rest can use the name the server uses
| return []; | ||
| } | ||
|
|
||
| logRecords.map((logRecord) => { |
There was a problem hiding this comment.
this was doing mutation on the records. You'll see UT that were relying on that side effect to pass.
|
|
||
| No debug logs found in org | ||
|
|
||
| # appColHeader |
There was a problem hiding this comment.
a message for table headers seemed silly--we don't normally do that
| ]); | ||
| }); | ||
|
|
||
| it('will list multiple logs --json', async () => { |
There was a problem hiding this comment.
wasn't actually testing --json, though asserting the result is kinda like it.
| expect(result).to.deep.equal(logRecords); | ||
| sandbox.stub(LogService.prototype, 'getLogRecords').resolves(structuredClone(logRecords)); | ||
| await new Log([], config).run(); | ||
| expect(tableStub.firstCall.args[0]).to.deep.equal([ |
There was a problem hiding this comment.
had to change the test because the implementation doesn't make all the new columns anymore.
doesn't assert the output structure since the next test does that
|
had to push some changes to fix NUTs/merge conflicts, see last 2 commits QA notes: ✅ |
2 participants
What does this PR do?
general cleanup
What issues does this PR fix or reference?
@W-15999434@
testing notes
I tested this using dreamhouse.
you can
tail logan org and it'll set the log capture stuff. Open the PropertyExplorer to start seeing logs.once you've done that, you can also
list logandget logfrom the generated logs