Skip to content

Conversation

soridalac
Copy link
Contributor

What does this PR do?

Add "--detailed-coverage" flag to "sf apex get test"

What issues does this PR fix or reference?

@W-16744604@

@soridalac soridalac requested a review from a team as a code owner October 1, 2024 18:03
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one request to remove yarn from plugin deps

package.json Outdated
"@salesforce/sf-plugins-core": "^11.3.7",
"ansis": "^3.3.1"
"ansis": "^3.3.1",
"yarn": "^1.22.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn got into the plugin deps, remove it with yarn remove yarn

@jshackell-sfdc
Copy link
Contributor

@soridalac : The command description of apex run test includes this line, which I think will also apply to apex get test now that you're adding --detailed-coverage:

To see code coverage results, use the --code-coverage flag with --result-format. The output displays a high-level summary of the test run and the code coverage values for classes in your org. If you specify human-readable result format, use the --detailed-coverage flag to see detailed coverage results for each test method run.

If you agree, can you add the same line to apex get test? Add it as its own paragraph to the # description header in the markdown file, right after the sentence that starts "Provide a test run...". Thanks!

FYI @cristiand391

@cristiand391
Copy link
Member

QA notes:

setup:
checked out the PR, yarn && yarn install then linked via sf plugins link --no-install
using a fresh dreamhouse scratch org

✅ can get codecov from a test run
✅ can get detailed coverage from a test run
✅ using --detailed-coverage without --code-coverage fails

@cristiand391 cristiand391 merged commit 1e66e83 into main Oct 1, 2024
13 checks passed
@cristiand391 cristiand391 deleted the code-coverage branch October 1, 2024 20:12
@iowillhoit iowillhoit changed the title Code coverage W-16744604 Code coverage Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants