Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lightning url check from sfdx-core #955

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

let sfdx-core define lightning domains in one place (sfdcUrl)

What issues does this PR fix or reference?

@W-15153669@

@cristiand391
Copy link
Member

QA notes:

✅ web login command still blocks lightning URLs
✅ instance URLs work

@cristiand391 cristiand391 merged commit c5921ec into main Mar 25, 2024
12 checks passed
@cristiand391 cristiand391 deleted the sm/lightning-url-check-from-sfdx-core branch March 25, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants