Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Drop Sammyjo20 from namespace #105

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Conversation

Sammyjo20
Copy link
Member

To help keep things tidy I have decided to remove "Sammyjo20" from the namespace.

@what-the-diff
Copy link

what-the-diff bot commented Nov 13, 2022

  • Renamed the namespace from Sammyjo20\Saloon to Saloon
  • Updated all references of Sammyjo20\Saloon in composer.json and src/Actions/SendRequest.php
  • Added a new file called README-SAMMYJO20-SALOON_TO_SALOON which contains this text, so that we can see what has changed between versions 1.* and 2.*
  • Changed namespace from Sammyjo20\Saloon to Saloon
  • Removed use statements for the old namespaces and replaced with new ones
  • Renamed the namespace from Sammyjo20\Saloon to Saloon
  • Updated all references of Sammyjo20\Saloon to Saloon
  • Changed namespace from Sammyjo20\Saloon to Saloon
  • Removed the use of a helper class in HasCustomResponses trait
  • Added missing exception classes for InvalidPoolItemException and ClassNotFoundException
  • Changed the namespace of all classes to Saloon
  • Updated composer.json file with new name and description
  • Added a README for this package, which is now called saloon-php/saloon (previously sammyjo20/saloon)
  • Changed the namespace of all classes from Sammyjo20\Saloon to Saloon
  • Removed use statements for Sammyjo20\Saloon and replaced with Saloon
  • Replaced any references to \Sammyjo20\Saloon in code comments or strings with \Salooan
  • Changed namespace from Sammyjo20\Saloon to Saloon
  • Removed the use of a missing class (Sammyjo20\MissingClass)
  • Added new test classes for testing invalid responses and requests, as well as OAuth 2 support
  • Updated all tests to reflect changes in namespaces and added new ones where necessary
  • Changed the namespace of all files from Sammyjo20\Saloon to Saloon
  • Removed use statements for classes that were in the old namespace and added them back with new namespaces
  • Changed namespace from Sammyjo20\Saloon to Saloon
  • Removed use statements for the old namespaces and added new ones
  • Changed the namespace of all files in tests/Fixtures from Sammyjo20\Saloon to Saloon
  • Updated composer.json with new package name and description
  • Renamed vendor folder to src (to match PSR-4)
  • Changed the namespace from Sammyjo20\Saloon to Saloon
  • Added a new test for testing that you can change the default fixture path in MockConfigTest.php
  • The namespace of the classes in tests/Unit folder has been changed from Sammyjo20\Saloon to Saloon.
  • In RequestManagerTest, UserRequestWithBootConnector class is used instead of UserRequestWithBootConnectors class which does not exist anymore.

Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit f76460f into v2 Nov 13, 2022
@Sammyjo20 Sammyjo20 deleted the feature/v2-namespaces branch November 13, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant