Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | AlwaysThrowOnErrors Priority #114

Merged
merged 2 commits into from
Nov 26, 2022
Merged

Conversation

Sammyjo20
Copy link
Member

@Sammyjo20 Sammyjo20 commented Nov 26, 2022

This fixes a bug with the AlwaysThrowOnErrors trait and the fixture recorder. Due to the traits being loaded before the fixture recorder - the exception was being thrown. I've added a new prepend parameter which will add a middleware to the top of the pipeline.

@Gummibeer - hope you are well! This should fix the issues you were having :)

Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 marked this pull request as ready for review November 26, 2022 14:13
@Sammyjo20 Sammyjo20 merged commit bd47b61 into v2 Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant