Add function arity checking to calc example #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for salsa-rs processing.
|
✅ Deploy Preview for salsa-rs canceled.
|
xffxff
requested changes
Feb 10, 2023
| self.report_error( | ||
| expression.span, | ||
| format!( | ||
| "the function `{}` expects {expected_arity} argument(s), only {actual_arity} provided", |
There was a problem hiding this comment.
Suggested change
| "the function `{}` expects {expected_arity} argument(s), only {actual_arity} provided", | |
| "the function `{}` expects {expected_arity} argument(s), but {actual_arity} provided", |
I think it would be better to change it to "but", because the actual_arity may be more than the expected_arity, as in your test sample below
nikomatsakis
approved these changes
Jun 19, 2024
|
This needs to be rebased before landing, any change you are still interested, @pervognsen ? Also, we're doing a renewed push around "Salsa 3.0" if you are still interested in doing more contribution. |
|
Going to close this since there has been so much activity! Still relevant though, let's come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to poke around Salsa 2022 and noticed the calc example's type checker doesn't validate the arity of function calls. Hopefully I'll be able to make more substantial contributions in the future when I get my bearings.