Check for application types based on static code analysis #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveworley
commented
Jan 5, 2023
steveworley
commented
- Adds a deterministic sniff for application type
- Static code analysis with threshold scanning for app types.
yusufhm
reviewed
Jan 23, 2023
There was a problem hiding this comment.
@steveworley looking good overall; just a couple of questions
| utils.MergeStringSlice(&c.Disallowed, appTypeCheck.Disallowed) | ||
| utils.MergeStringSlice(&c.Paths, appTypeCheck.Paths) | ||
| c.Threshold = appTypeCheck.Threshold | ||
|
|
There was a problem hiding this comment.
I see the other fields are not being merged - would that be on purpose?
There was a problem hiding this comment.
Mostly because I wasn't sure how the merge would happen with map[string][]string as opposed to []string, but also because I thought we wouldn't be changing the markers when we override.
yusufhm
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.