This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Fixing dryrun add debug #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror checking when commands fail and halting the run when this happens.
nicholasmhughes
approved these changes
Dec 21, 2023
Comment on lines
+116
to
+119
| ret = run_command(cmd) | ||
| if ret.returncode != 0: | ||
| print(f"Failure: {ret.stderr}") | ||
| sys.exit(ret.returncode) |
There was a problem hiding this comment.
suggestion (non-blocking): this block is repeated a bunch. it might be good to move the logic up into run_command at some point in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing dryrun add debug