Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support delete the folder #12

Closed
saltbo opened this issue Sep 9, 2020 · 4 comments
Closed

support delete the folder #12

saltbo opened this issue Sep 9, 2020 · 4 comments
Assignees
@XiangYu0777
Labels
BE backed enhancement New feature or request
Milestone
v1.3

Comments

@saltbo
Copy link
Owner

saltbo commented Sep 9, 2020

No description provided.

@saltbo saltbo added this to the v1.3 milestone Sep 9, 2020
@saltbo saltbo added BE backed enhancement New feature or request labels Sep 9, 2020
@XiangYu0777
Copy link
Contributor

XiangYu0777 commented Sep 9, 2020 •
edited
Loading

Received.

@XiangYu0777
Copy link
Contributor

Hi, @saltbo Whether we should keep the files of the folder when deleting it.

@saltbo
Copy link
Owner Author

saltbo commented Sep 15, 2020 •
edited
Loading

It means that delete all files of the folder.

Implement a delete API for the folder, you could develop base on ObjectsDelete

zpan/disk/provider.go

Line 17 in e3b9612

ObjectsDelete(keys []string) error

saltbo added a commit that referenced this issue Sep 20, 2020
@saltbo
refactor: update the service to improve the test coverage && support …
5cea121 
…delete the folder && support i18n #7 #8 #12
@saltbo
Copy link
Owner Author

saltbo commented Sep 20, 2020

Thanks for your contribution, But I refactor it by soft delete. Because we would like to implement a Recycle Bin, You can continue to contribute related code.

@saltbo saltbo closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XiangYu0777 XiangYu0777

Labels
BE backed enhancement New feature or request
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
2 participants
@saltbo @XiangYu0777