fix:don't allow move the folder into itself #4 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
holicc
commented
Sep 11, 2020
•
holicc
commented
- Fix : don't allow move the folder into itself
- Fix : moving folder with children
saltbo
reviewed
Sep 11, 2020
|
The front end needs to filter itself in the dialog window |
XiangYu0777
pushed a commit
to XiangYu0777/zpan
that referenced
this pull request
Sep 15, 2020
XiangYu0777
pushed a commit
to XiangYu0777/zpan
that referenced
this pull request
Sep 15, 2020
fix:don't allow move the folder into itself #4 (saltbo#26) * fix:don't allow move the folder into itself #4 * fix: action building failed * refactor: splitting logic as FileMove and FolderMove Co-authored-by: lu.longshan <luls0728@zsmarter.com> chore: update the front code to resolve #4 fix: resolve the issue #5 feat: support s3 and storage saltbo#10 chore: update the front code to resolve saltbo#11 feat: support search to resolve the issue saltbo#13 chore: update the assets to fix create folder test: add some ut for the disk
XiangYu0777
pushed a commit
to XiangYu0777/zpan
that referenced
this pull request
Sep 15, 2020
fix:don't allow move the folder into itself #4 (saltbo#26) * fix:don't allow move the folder into itself #4 * fix: action building failed * refactor: splitting logic as FileMove and FolderMove Co-authored-by: lu.longshan <luls0728@zsmarter.com> chore: update the front code to resolve #4 fix: resolve the issue #5 feat: support s3 and storage saltbo#10 chore: update the front code to resolve saltbo#11 feat: support search to resolve the issue saltbo#13 chore: update the assets to fix create folder test: add some ut for the disk
XiangYu0777
pushed a commit
to XiangYu0777/zpan
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.