Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:SALTO-13 Added settings filter #337

Merged
merged 36 commits into from
Nov 6, 2019

Conversation

orendig
Copy link
Contributor

@orendig orendig commented Nov 4, 2019

No description provided.

@orendig orendig added the WIP Work in progress label Nov 4, 2019
@orendig orendig self-assigned this Nov 4, 2019
roironn and others added 14 commits November 4, 2019 20:00
* added error severity in extension
* upgraded inquirer.js to fix hang in Windows 10
* moved accesses to fs module to centralized file module
* using tmp-promise instead of tmp
…SALTO-13-settings_support

# Conflicts:
#	packages/salesforce-adapter/src/filters/convert_types.ts
#	packages/salesforce-adapter/src/filters/settings_type.ts
#	packages/salesforce-adapter/src/transformer.ts
#	packages/salesforce-adapter/test/filters/settings_type.test.ts
#	packages/salto/test/parser/parse.test.ts
List ordering for specific ObjectTypes and records (InstanceElements)
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@71e27da). Click here to learn what that means.
The diff coverage is 96.53%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage          ?   95.53%           
=========================================
  Files             ?      107           
  Lines             ?     4327           
  Branches          ?      787           
=========================================
  Hits              ?     4134           
  Misses            ?      193           
  Partials          ?        0
Flag Coverage Δ
#unit_test 95.53% <96.53%> (?)
Impacted Files Coverage Δ
packages/salesforce-adapter/src/constants.ts 100% <ø> (ø)
packages/salto-vscode/src/salto/diagnostics.ts 100% <ø> (ø)
packages/salto/src/workspace/config.ts 95.23% <100%> (ø)
packages/cli/src/workspace.ts 100% <100%> (ø)
packages/salto/src/core/fetch.ts 100% <100%> (ø)
packages/cli/src/commands/import.ts 91.3% <100%> (ø)
packages/salto/src/workspace/cache.ts 100% <100%> (ø)
packages/cli/src/argparser.ts 97.56% <100%> (ø)
packages/salesforce-adapter/src/adapter.ts 97.5% <100%> (ø)
packages/cli/src/cli.ts 97.29% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e27da...9930f2a. Read the comment docs.

@orendig orendig merged commit 09448c9 into salto-io:master Nov 6, 2019
@orendig orendig deleted the SALTO-13-settings_support branch November 6, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants