Fix test suite and move to pytest-salt-factories #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Github Actions workflow to call tox and run tests. Doesn't currently implement coverage functionality - will add that later.
Adds an exclusion for master and python 3.5/3.6 as 3006 onwards requires py 3.7.
Updates pytest-salt url to point to https://github.com/vmware-archive/pytest-salt. Should re-work tests to use pytest-salt-factories.
Updates requirements to match current salt requirements for zeromq and tornado.
Drops testing of python 3.5 and 3.6 - moving to pytest-salt-factories will remove support for those in it's 1.x releases.
Updates testing requirements.txt: * Use modern version of pytest * Use pytest-salt-factories rather than pytest-salt
Updates tox.ini to use new pytest options for output.
Updates test fixture to use pytest-salt-factories rather than the now archived pytest-salt.
Updates client integration tests to work with pytest-salt-factories. Also update xfails to handle newer pytest.
Uses importlib-metadata<5.0.0 for python3.7 on 3004.2 and 3005.1 to work around a bug in salt.utils.entrypoints when using pytest-salt-factories.
|
@nicholasmhughes - any chance you could take a look at this? @s0undt3ch - if you have a second to look over this to see if I've done anything foolish with pytest-salt-factories, that would be much appreciated! |
garethgreenaway
approved these changes
Apr 18, 2023
|
@garethgreenaway - could you turn off the requirement for Travis CI on this repo? I don't have sufficient perms for for that and we can merge currently. |
nicholasmhughes
approved these changes
Apr 18, 2023
This was referenced May 1, 2023
Closed
|
Sorry it took me this long. 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with test suite:
Includes changes in #226 that haven't yet been merged, maybe be worth just closing that and merging this instead.