upgrade salt-pylint to work with pylint 3.0.3 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current saltpylint works with pylint==2.13.9. It does not work with newer versions of pylint such as 2.17 ... 3.0.3. Pylint 3.0.3 includes many code changes, such as remove exposed checker interfaces, remove some @utils fucitons, remove checker member functions (config) .. The submitted pr removes those disappeared functions. Review is required to make sure it does not remove necessary checks as a result. This commit will fix issues - saltstack#48 - saltstack#47
|
@s0undt3ch would you mind having a look please? =) |
s0undt3ch
requested changes
Feb 1, 2024
|
|
||
| def open(self): | ||
| super(ThirdPartyImportsChecker, self).open() | ||
| self.cwd = os.getcwd() | ||
| self.allowed_3rd_party_modules = set(self.config.allowed_3rd_party_modules) # pylint: disable=no-member |
There was a problem hiding this comment.
Why don't we want a set?
The set would remove duplicates
saltpylint/strings.py
Outdated
| @@ -151,8 +134,7 @@ def visit_call(self, node): | |||
| ) | |||
|
|
|||
| if BAD_FORMATTING_SLOT.findall(inferred.value): | |||
| if self.config.un_indexed_curly_braces_always_error or \ | |||
| sys.version_info[:2] < (2, 7): | |||
| if sys.version_info[:2] < (2, 7): | |||
There was a problem hiding this comment.
Any Py2 code or logic can just be removed
There was a problem hiding this comment.
removed and add back in un_indexed_curly_braces_always_error check
saltpylint/strings.py
Outdated
| msgid = 'E1321' | ||
| else: | ||
| msgid = 'W1321' | ||
| msgid = 'W1321' |
There was a problem hiding this comment.
Why are we no longer caring for string_substitutions_usage_is_an_error ?
saltpylint/blacklist.py
Outdated
| except ValueError: | ||
| pass | ||
| else: | ||
| self.blacklisted_functions[key] = val |
There was a problem hiding this comment.
We no longer need the previous logic?
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
…nfig. - remove Py2 code check
|
@s0undt3ch thx for looking into my pr. Please check my latest commits which address all your review comments |
s0undt3ch
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current saltpylint works with pylint==2.13.9. It does not work with
newer versions of pylint such as 2.17 ... 3.0.3. Pylint 3.0.3 includes
many code changes, such as remove exposed checker interfaces, remove
some https://github.com/utils fucitons, remove checker member functions (config) .. The
submitted pr removes those disappeared functions. Review is required to
make sure it does not remove necessary checks as a result.
This commit will fix issues