-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows minion downloads are not updated when new releases are made #25057
Comments
There are installers for the newer builds. Where are you looking for them? |
Loren,
Short version, I end up at the http://docs.saltstack.com/en/latest/topics/installation/windows.html http://docs.saltstack.com/en/latest/topics/installation/windows.html doc link and it only goes up to 2015-5.0-2 version. Hence my issue I raised. Long version, well my steps are usually.
which stops at the 2015.5.0-2 http://docs.saltstack.com/downloads/Salt-Minion-2015.5.0-2-x86-Setup.exe versions. ;-) OK, I will get busy doing/updating the windows winner sls files for the updated x86 and AMD64 versions of the newer salt minions. BTW do you happen to know who one would speak to about saltstack adding the building of the new or updated minion windows winrepo sls files to the build or release process? @UtahDave |
See the PR I just opened. Added the links to the Windows installation doc page. There's always a delta between when the installers are built and when the doc page is updated. Personally, when I'm checking for new versions, I always just go straight to the download link, http://docs.saltstack.com/downloads/. I'm not sure myself what you mean by 'new or updated minion winrepo sls files'. But If it's part of a public project on github, I'd recommend cloning it, updating the files, and submitting a PR. |
That is exactly what I have been doing, for every release as and when I remembered. But it just seems strange that a community member has to do that when it should really be part and parcel of a (hopefully automated or scripted) new release or update process inside of saltstack, for each version update of salt.
|
OK, so this issue is resolved with the raising of the PR that @lorengordon just opened, but I can't see or find this new PR? So I coudl clsoe this issue with a proper reference to it? |
Oh, my bad, I linked the commit, but not the PR. The commit is what closes the issue when it's merged, the PR is for convenience. 😉 Here's the PR: #25065. |
Thanks. I keep learning new things every day, thouhgt I had to refer to it in my issue closing comment. ;-) So even the close of the issue is already sorted too. ;-) |
I have now created salt-winrepo PRs saltstack/salt-winrepo#221 saltstack/salt-winrepo#220 saltstack/salt-winrepo#219 and saltstack/salt-winrepo#218 to create the newly updated salt-winrepo sls files for the windows salt minions. |
@TheBigBear, thanks for the report. Updating the download links should probably be automated, or we should make sure to do it every release. |
How is a build of the newer installer of the windows salt-minion triggered? @UtahDave
It seems strange to me, that there is still no 2015.5.1 or 2015.5.2 windows salt minion installer posted?
The text was updated successfully, but these errors were encountered: