Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not use file.line on Windows #34665

Closed
andras-tim opened this issue Jul 14, 2016 · 1 comment
Closed

Can not use file.line on Windows #34665

andras-tim opened this issue Jul 14, 2016 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Milestone
Approved

Comments

@andras-tim
Copy link
Contributor

andras-tim commented Jul 14, 2016 •
edited by rallytime
Loading

Description of Issue/Question

Can not use file.line on Windows, because it is not passed through in win_file.py

Steps to Reproduce Issue

  1. use file.line in a state file what will be evaluated on a Windows host
  2. run a state.apply

Versions Report

    Salt Version:
               Salt: 2016.3.1

    Dependency Versions:
               cffi: 1.6.0
           cherrypy: 5.3.0
           dateutil: 2.5.3
              gitdb: 0.6.4
          gitpython: 2.0.2
              ioflo: 1.5.3
             Jinja2: 2.8
            libgit2: Not Installed
            libnacl: Not Installed
           M2Crypto: Not Installed
               Mako: 1.0.4
       msgpack-pure: Not Installed
     msgpack-python: 0.4.7
       mysql-python: Not Installed
          pycparser: 2.14
           pycrypto: 2.6.1
             pygit2: Not Installed
             Python: 2.7.12 (v2.7.12:d33e0cf91556, Jun 27 2016, 15:19:22) [MSC v.1500 32 bit (Intel)]
       python-gnupg: 0.3.8
             PyYAML: 3.11
              PyZMQ: 15.2.0
               RAET: Not Installed
              smmap: 0.9.0
            timelib: 0.2.4
            Tornado: 4.3
                ZMQ: 4.1.2

    System Versions:
               dist:   
            machine: x86
            release: 2003Server
             system: Windows
            version: 2003Server 5.2.3790 SP2 Uniprocessor Free
andras-tim added a commit to andras-tim/salt that referenced this issue Jul 14, 2016
@andras-tim
Fixed file.line on Windows - fix saltstack#34665
d7dd0ac
@andras-tim andras-tim mentioned this issue Jul 14, 2016
Merged
@rallytime
Copy link
Contributor

Thanks for the fix @andras-tim!

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Jul 14, 2016
@rallytime rallytime added this to the Approved milestone Jul 14, 2016
gitebra pushed a commit to gitebra/salt that referenced this issue Jul 15, 2016
@jojohans
Merge remote-tracking branch 'upstream/develop' into develop
1260f2b 
* upstream/develop:
  Fixed file.line on Windows - fix saltstack#34665 (saltstack#34666)
  Revert "Modify lodaer global test to use populated dunders"
  INI uses proper line endings - fix saltstack#34667
  Spelling fixes found in sqlite3 pillar docs (saltstack#34652)
  Lint 34644 (saltstack#34651)
  Adjust the mine test a little bit to give it a better chance of success (saltstack#34647)
  catch error if no dns domains exist
  Check that mysqladmin exists before running mysql integration tests.
  add num_cpus grain to freebsd (saltstack#34565)
  Fixes failing test on Suse Leap (saltstack#34621)
  Changed network state test to use test=True
  Clarifies the proper way to reference states
  Some small changes
  handle jboss cli expression type in the parsing of the output
  Change network state integration test to use test=True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@andras-tim @rallytime