Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SALT.STATES.APACHE_MODULE needs version annotations #35458

Closed
iggy opened this issue Aug 15, 2016 · 4 comments
Closed

SALT.STATES.APACHE_MODULE needs version annotations #35458

iggy opened this issue Aug 15, 2016 · 4 comments
Assignees
@rallytime
Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
C 5

Comments

@iggy
Copy link
Contributor

iggy commented Aug 15, 2016

Description of Issue/Question

In 2016.3 apache_modules.enable was renamed to apache_modules.enabled and some transitional aliases were put in place.

There was nothing added to the documentation about when this was changed, so people look at the docs, and don't realize they can only use .enabled on the absolute latest version.

Please add the version annotations to the code and rebuild the docs.
@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 16, 2016

@iggy agreed this needs to be updated. Thanks for the notice. Looks like it was added here: #29651 which made its way into 2016.3.0+

@Ch3LL Ch3LL added Documentation Relates to Salt documentation Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P4 Priority 4 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Aug 16, 2016
@Ch3LL Ch3LL added this to the Approved milestone Aug 16, 2016
@rallytime rallytime mentioned this issue Aug 16, 2016
Merged
@rallytime
Copy link
Contributor

@iggy How does #35495 look to you? That should help clear up when the deprecation path started.

@rallytime rallytime added TEAM Core fixed-pls-verify fix is linked, bug author to confirm fix and removed RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Aug 16, 2016
@rallytime rallytime modified the milestones: C 5, Approved Aug 16, 2016
@rallytime rallytime self-assigned this Aug 16, 2016
@iggy
Copy link
Contributor Author

iggy commented Aug 24, 2016

That is a good addition. I more meant that .enabled() was added without version added annotations... People keep trying to use it on older versions.

rallytime pushed a commit to rallytime/salt that referenced this issue Aug 24, 2016
Add versionadded for enabled function in apache_module state
7dcb95d 
Refs saltstack#35458
@rallytime rallytime mentioned this issue Aug 24, 2016
Merged
@rallytime
Copy link
Contributor

@iggy Bah! You're right. I remember when I was fixing that I thought I did see a versionadded already for the enabled function. But after looking again, it's definitely not there. I've added one in #35732. Thanks for double checking!

rallytime pushed a commit that referenced this issue Aug 24, 2016
Add versionadded for enabled function in apache_module state (#35732)
dab8428 
Refs #35458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rallytime rallytime

Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
C 5
Development

No branches or pull requests
3 participants
@iggy @rallytime @Ch3LL