Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pip-tools-compile pre-commit hook does not work on windows #56642

Closed
Ch3LL opened this issue Apr 14, 2020 · 1 comment
Closed

[BUG] pip-tools-compile pre-commit hook does not work on windows #56642

Ch3LL opened this issue Apr 14, 2020 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists Windows
Milestone

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Apr 14, 2020

Description
pre-commit does not work on windows currently. Anyone developing on windows will run into this error

stderr:
    Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\jeaco\\AppData\\Local\\Temp\\pip-uninstall-1vpi1i28\\users\\user\\.cache\\pre-commit\\repo\\py_env-python3\\scripts\\pip.exe'

There is a current workaround to export SKIP=pip-tools-compile. This will skip the pre-commit tool pip-tools-compile and run the rest of pre-commit, but this still means that pip-tools-compile does not work on windows.

Setup
run git commit on windows or pre-commit run

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists P4 Priority 4 labels Apr 14, 2020
@Ch3LL Ch3LL added this to the Approved milestone Apr 14, 2020
@Ch3LL Ch3LL changed the title [BUG] pre-commit does not work on windows [BUG] pip-tools-compile pre-commit hook does not work on windows Apr 14, 2020
Ch3LL added a commit to Ch3LL/salt that referenced this issue Apr 14, 2020
Ch3LL added a commit that referenced this issue Apr 15, 2020
Add warning in doc about issue #56642
@sagetherage sagetherage removed the P4 Priority 4 label Jun 3, 2020
@sagetherage sagetherage added Windows Magnesium Mg release after Na prior to Al labels Jul 20, 2020
@sagetherage sagetherage modified the milestones: Approved, Magnesium Jul 20, 2020
@sagetherage sagetherage removed the Magnesium Mg release after Na prior to Al label Aug 13, 2020
@sagetherage sagetherage modified the milestones: Magnesium, Approved Aug 13, 2020
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Sep 6, 2023

Closing as this was documented that it needs to be run on OSs other than windows

@Ch3LL Ch3LL closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists Windows
Projects
Status: Done
Development

No branches or pull requests

2 participants