[BUG] pkg.installed version matching fails on CentOS 7

[rossengeorgiev]

Description
It appears version matching considers the release as part of version, and fails to match the specified version in the state

Relevant log:

[INFO    ] Running state [kibana] at time 12:55:28.675700
[DEBUG   ] Could not LazyLoad pkg.resolve_capabilities: 'pkg.resolve_capabilities' is not available.
[WARNING ] Please install a package that provides rpm.labelCompare for more accurate version comparisons.
[WARNING ] Falling back on salt.utils.versions.version_cmp() for version comparisons
[DEBUG   ] Could not LazyLoad pkg.check_db: 'pkg.check_db' is not available.
[DEBUG   ] Could not LazyLoad pkg.check_extra_requirements: 'pkg.check_extra_requirements' is not available.
[DEBUG   ] Could not LazyLoad pkg.version_clean: 'pkg.version_clean' is not available.
[WARNING ] Please install a package that provides rpm.labelCompare for more accurate version comparisons.
[WARNING ] Falling back on salt.utils.versions.version_cmp() for version comparisons
[DEBUG   ] Current version (['6.5.4-1']) did not match desired version specification (6.5.4), adding to installation targets

Setup

# rpm -q kibana
kibana-6.5.4-1.x86_64

Steps to Reproduce the behavior

1. Run following state, with kibana package already installed.

kibana:
  pkg.installed:
    - version: 6.5.4

2. We get the fallowing result when we run with test=true:

----------
          ID: kibana
    Function: pkg.installed
      Result: None
     Comment: The following packages would be installed/updated: kibana=6.5.4
     Started: 12:55:29.215411
    Duration: 474.698 ms
     Changes:

Summary for local

If ran without test, it fails:

----------
          ID: kibana
    Function: pkg.installed
      Result: False
     Comment: The following packages failed to install/update: kibana=6.5.4
     Started: 13:03:17.561401
    Duration: 32915.894 ms
     Changes:
----------

Expected behavior
Report that the package is already installed

Versions Report

salt --versions-report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

Salt Version:
           Salt: 3001

Dependency Versions:
           cffi: 1.14.1
       cherrypy: Not Installed
       dateutil: Not Installed
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
         Jinja2: 2.11.1
        libgit2: 1.0.0
       M2Crypto: 0.35.2
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.6.2
   mysql-python: Not Installed
      pycparser: 2.20
       pycrypto: Not Installed
   pycryptodome: Not Installed
         pygit2: 1.2.1
         Python: 3.6.8 (default, Apr  2 2020, 13:34:55)
   python-gnupg: Not Installed
         PyYAML: 3.13
          PyZMQ: 17.0.0
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.1.4

System Versions:
           dist: centos 7 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-1127.el7.x86_64
         system: Linux
        version: CentOS Linux 7 Core

[cmcmarrow]

Thanks for the report @rossengeorgiev. I also confirmed this to be a bug

[rossengeorgiev]

I think it works correctly if python36-rpm from EPEL is installed, which is not by default.

[rossengeorgiev]

Yep, installing python36-rpm makes the issue go away. #57972 seems related

[bryceml]

python36-rpm is in the repos for 3002 and newer, so this shouldn't be a problem with 3002 and newer.

Please let me know if that solves the problem and we can close this issue.

[sagetherage]

@rossengeorgiev please let us know if that solves the problem and we can close this issue ^^

[rossengeorgiev]

Installing python-rpm originally solved the issue, so if it is now included then, yes. Thanks!