ssh_auth.absent test=true traceback

[Mrten]

(0.17.1) If I run state.highstate test=true I get this traceback:

database-1:
----------
    State: - ssh_auth
    Name:      AAAAB3NzaC1yc2EAAAADAQABAAABAQDorb3OUWqs5QnHoua6G3AX7QSbaLcl[..]    
Function:  absent
        Result:    False
        Comment:   An exception occurred in this state: Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/salt/state.py", line 1260, in call
    ret = self.states[cdata['full']](*cdata['args'])
  File "/usr/lib/pymodules/python2.7/salt/states/ssh_auth.py", line 258, in absent
    config)
  File "/usr/lib/pymodules/python2.7/salt/modules/ssh.py", line 283, in check_key
    enc = _refine_enc(enc)
  File "/usr/lib/pymodules/python2.7/salt/modules/ssh.py", line 55, in _refine_enc
    raise CommandExecutionError(msg)
CommandExecutionError: Incorrect encryption key type "".

        Changes:

But I don't get it with a normal run.

[holmboe]

I am sending a PR soonish.

[Mrten]

0.17.2, still seeing this.

[Mrten]

pokes @basepi should this have been in 0.17.2?

[basepi]

Looks like the answer is yes. The title of the commit message made me think it was a feature, though ("Add ..."). I'll get it in for 0.17.3.

[basepi]

Erm, on second inspection, it looks like it did make it. https://github.com/saltstack/salt/blob/v0.17.2/salt/states/ssh_auth.py#L229-L234

o_O

[Mrten]

I noticed it in the changelog, though: http://docs.saltstack.com/topics/releases/0.17.2.html

I'll double-check the versions, I'm pretty sure that I ran the state that upgrades everything today but salt is kinda flaky lately.

[Mrten]

I did run the upgrade state but it didn't catch on the minion.

root@salt-master:/home/salt/conf/all-syslog# salt '*' state.sls all-salt-minion-config
Executing job with jid 20131119121745708315
-------------------------------------------
Execution is still running on backup-1
...
[and a lot of 'minion did not return's.]

I'm used to salt returning 'minion did not return' lately, but usually it means the state ran OK, but this time it didn't.

root@salt-master:/home/salt/conf/machine/web/users# salt 'database-3' cmd.run 'salt-call --versions'
Executing job with jid 20131119214655274043
-------------------------------------------

database-3:
               Salt: 0.17.1
             Python: 2.7.3 (default, Sep 26 2013, 20:03:06)
             Jinja2: 2.6
           M2Crypto: 0.21.1

I'm sorry for the work, I'll kick it again. Any idea on how to debug something like this (minions not returning)?

[basepi]

Salt has been flaky for awhile as far as its ability to upgrade itself. We're trying to find the problem and fix it, sorry for the inconvenience. =\