Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain all software from the registry #23433

Merged
merged 2 commits into from
May 11, 2015
Merged

Obtain all software from the registry #23433

merged 2 commits into from
May 11, 2015

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented May 6, 2015

Simplified how salt obtains list of installed software:

  • Removed Powershell script that uses WMI to get a list software installed with msiexec
  • Removed registry portion that tries to get list from individual registry hives
  • Removed logic that tried to filter software that was installed with msiexec

It seems that the two registry locations are enough:

  • HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall
  • HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall

@UtahDave needs to look at this before Merging

Fixes #23004

@twangboy twangboy mentioned this pull request May 8, 2015
Closed
@twangboy
Copy link
Contributor Author

twangboy commented May 8, 2015

Just tested on 32bit. Works great.

@twangboy
Copy link
Contributor Author

@UtahDave rebased

UtahDave added a commit that referenced this pull request May 11, 2015
@UtahDave
Merge pull request #23433 from twangboy/list_pkgs_fix
55c3869 
Obtain all software from the registry
@UtahDave UtahDave merged commit 55c3869 into saltstack:2014.7 May 11, 2015
@UtahDave
Copy link
Contributor

nice!

@twangboy twangboy mentioned this pull request Jun 29, 2015
Closed
@twangboy
Copy link
Contributor Author

Fixed #17948

@twangboy twangboy mentioned this pull request Jul 7, 2015
Closed
@twangboy
Copy link
Contributor Author

Should also fix this issue: #11341

@rallytime rallytime mentioned this pull request Jan 27, 2016
Closed
@twangboy twangboy deleted the list_pkgs_fix branch February 18, 2016 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twangboy @UtahDave @jfindlay