Minimize DNS resolution queries on grains load #29346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When grains are loaded, hostname() is called multiple times. The hostname() function ends up calling socket.getfqdn, which is an expensive operation if the host is not on the domain (the function times out). Optimize grains operation to only query getfqdn once. Also , optimize fqdn_ip4 and fqdn_ipv6 grains to only call socket.getaddrinfo (expensive operation) if there is a domain. Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
|
This is an excellent addition and should also optimize the use of |
cachedout
pushed a commit
that referenced
this pull request
Dec 2, 2015
Minimize DNS resolution queries on grains load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grains are loaded, hostname() is called multiple times. The
hostname() function ends up calling socket.getfqdn, which is an
expensive operation if the host is not on the domain (the function times
out). Optimize grains operation to only query getfqdn once. Also , optimize
fqdn_ip4 and fqdn_ipv6 grains to only call socket.getaddrinfo (expensive
operation) if there is a domain.
Signed-off-by: Alejandro del Castillo alejandro.delcastillo@ni.com