verify_env function for windows #33062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create win_verify_env to create directories for windows minion and master. Uses functions from win_functions - Fix stacktrace when minion starts when there's already a minion running. os.getppid doesn't work in windows. Created a function in win_functions to duplicate that functionality.
|
Hi @twangboy Just some lint here. The rest looks great. http://166.78.178.63:8080/job/PR/job/salt-pr-lint-n/1576/violations/ |
cachedout
added
the
Pending-Discussion
| # There is no os.getppid method for windows | ||
| from salt.utils import is_windows | ||
| if is_windows(): | ||
| from salt.utils.win_functions import get_parent_pid |
There was a problem hiding this comment.
This file already has 'import salt.utils' at the top. So I would skip the import and just use:
if salt.utils.is_windows():
There was a problem hiding this comment.
That's what I thought, but it wasn't resolving for me when I was doing it earlier. It is now though. I don't know what happened.
|
FYI |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
May 9, 2016
* commit '2dc45dc97ea0ac630e14988d05346dce27535a9a': verify_env function for windows (saltstack#33062) PY3: Fix dict keys when using salt.filesystem.FSChan (saltstack#33077) Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates
win_verify_envto handle folder creation and permissions for windowsFixes problem with missing
os.getppidmethod in windowsCreates win_functions util
What issues does this PR fix or reference?
https://github.com/saltstack/zh/issues/674
https://github.com/saltstack/zh/issues/675
Previous Behavior
Folders were not being created on minion/master start in windows
Stacktrace when launching minion/master when minion/master is running
New Behavior
Creates missing folders and adds permissions
Gracefully exits when instance is already running
Tests written?
No