-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libcloud bug #33367 #33518
Fix libcloud bug #33367 #33518
Conversation
Just committed a test for now to prove that this is currently broken. Then I'll fix the code and (hopefully) the test should pass |
CC @supertom |
@techhat Could you take a look please? |
build error "Traceback (most recent call last): |
@cachedout, LGTM. |
Thanks @tonybaloney for the fix! |
Need in 2016.3 |
You read my mind. I saw the release notes yesterday and realised this fix wasn't in there. +1. |
Done in #35235 |
What does this PR do?
Addresses the issue highlighted in #33367
What issues does this PR fix or reference?
#33367
Previous Behavior
libcloudfuncs do not support strings
New Behavior
libcloudfuncs will support node state as either a string or an integer
Tests written?
Yes