add acl unit tests #33684
Merged
add acl unit tests #33684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This says Could you please explain what's happening in your modification to |
cachedout
added
the
Pending-Discussion
|
I thought it was self-evident, sorry. |
|
These tests are not actually running. You need to add the new directory to the test runner, if I remember correctly. |
|
Bump @jfindlay |
|
@cachedout, they seem to be running now. I forgot to end the filename in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add acl unit tests
What issues does this PR fix or reference?
Tests written?
Yes