Update mac native package for upcoming release #33696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves an issue where the package `resources` and package `scripts` were being added to the root of the install drive. Change Spelling for: * xCode to XCode * and capitalize Command Line Tools to match Apple's offical documentation. Ref: https://developer.apple.com/xcode/ and https://developer.apple.com/library/ios/technotes/tn2339/_index.html
|
Signed off on by @twangboy Thanks, @clburlison . This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the package build process for the upcoming native mac package.
What issues does this PR fix or reference?
This solves an issue where the package
resourcesand packagescriptsdirectories were being added to the root of the install drive. Which is a big no-no.I also snuck a spelling change into this PR for:
to match Apple's official documentation.
Ref: https://developer.apple.com/xcode/ and https://developer.apple.com/library/ios/technotes/tn2339/_index.html
Lastly, added a directory
.gitignoreso temp files from the OS X package creation are never uploaded to git.Previous Behavior
New Behavior
Tests written?
No. However the I test the changes by creating a new package.
Super excited for the focus on OS X.
Thanks!