When getting all the top files for the various environments, those
environments without a top file will return ``False`` when we attempt to
cache the file. Passing a boolean to ``compile_template()`` will result
in an error being logged, since we are invoking the function incorrectly
(it expects the template data to be a string).

Since a ``False`` return from caching the file means that it does not
exist, this commit will only run ``compile_template()`` when the
contents evaluate to ``True``.

Resolves saltstack#33424.

Rather than excluding them from the get_tops() return data at all, just
populate them with empty dictionaries. This makes it easier to unit test
things like merge order, while still being functionally the same as
exlcluding the saltenv from get_tops() altogether.

…ository

Only compile the template contents if they evaluate to True

Fix win servermanager

On Gentoo, we should check the value passed in to timezone.set_hwclock
and only allow 'UTC' or 'localtime' for argument. If incorrect value is
passed in, it could subsequently fry the important config file.

There is another closely related issue on Gentoo. The value to set
'clock' variable in the config file is either 'UTC' or 'local'. In case
of localtime arg, we should convert the value of 'localtime' to 'local'
when setting that 'clock' variable.

Erik Johnson pointed out the speed issue with compelling numbers:

>>> import timeit
>>> t1 = timeit.Timer('clock == "localtime"', 'clock = "localtime"')
>>> t2 = timeit.Timer('clock.__eq__("localtime")', 'clock = "localtime"')
>>> t1.repeat()
[0.061421871185302734, 0.0285952091217041, 0.026736021041870117]
>>> t2.repeat()
[0.1310901641845703, 0.09536910057067871, 0.09479284286499023]

I'll absolutely fix it by using the simple '==' operator.

Thank you!

Closes saltstack#33554

fixup saltstack#33653

…urce is available

Make `configurable_test_state` configurable even in test mode and return
the correct result in test mode as per
https://docs.saltstack.com/en/latest/ref/states/writing.html#return-data.

Also adjust continued string indentation.

When the remote repository does not have a master branch, on the initial
checkout there will be no ref in refs/remotes/origin for this branch,
leading to an error being logged and the checkout failing.

Instead of failing the checkout, in these cases we'll create the initial
local HEAD based on the ref we will eventually check out, since we know
for a fact that this ref exists.

Resolves saltstack#33725

…epo-doc

Debian installation docs: drop section about community-maintained repo

Add exclude option to win_servermanager

Make `configurable_test_state` configurable in test mode

Fix git_pillar edge case for remote repos without a master branch

Back-port saltstack#33700 to 2015.8

…e-failures-in-SLE11-2015.8

Fix for groupadd execution module failures in SLES11 systems

Catch oserror for race condition

Closes saltstack#31219

Catch no minions exception in batch mode

The network.get_bufsize function requires an interface for arg. In the
example that part is missing. Add arbitrary 'eth0' for clarity.

…604-1939

Fix minor docstring issue of arg being missing

Gem integration test

service state integration tests

fix some problems with the gem module integration tests

states.pkg int tests: skip if pkg mgr unavailable

Closes saltstack#33810

This time win_servermanager

…er_test

Fixing more stupid unit tests

These all assert directly against mock objects. They're pointless.

…_tests

Remove matcher tests

…t_stacktrace

Fix another unit test stacktrace in pkg_resource

Fix broken locate.locate function

Conflicts:
  - salt/cli/salt.py
  - salt/modules/groupadd.py
  - salt/states/service.py