-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rpmbuild module work on non-RPM based GNU/Linux systems #34056
Conversation
We can't take this because it will cause an error with the Debian package build module, this will cause the Debian and the redhat pkgbuild modules to collide since they abstract a virtual interface. If you return the string 'rpmbuild' then it will be ok. |
if all required utilities are in place
Thank you @thatch45 ! Indeed, I haven't thought that if all dependencies met for both On the other hand, I've also changed Please review my last commit. |
Updated PR subj. Test failures seems not related to my changes... |
@@ -7,7 +7,7 @@ | |||
This system allows for all of the components to build rpms safely in chrooted | |||
environments. This also provides a function to generate yum repositories | |||
|
|||
This module impliments the pkgbuild interface | |||
This module implements the pkgbuild interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't make spelling mistakes as often as I used to, thanks!
Masterfully done! Thanks! |
What does this PR do?
Allows to build rpms and make YUM repositories on Debian operating systems.
I've successfully built rpm package and created a repository on Debian machine by installing the required tools using this sls:
What issues does this PR fix or reference?
None.
Previous Behavior
The
rpmbuild
execution module doesn't load on Debian GNU/Linux minion.New Behavior
The
rpmbuild
execution module andpkgbuild
state works on Debian.Tests written?
No