Catch CommandExecutionError in pkg states #34093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This likely needs a secondary fix, hold off on merging. |
|
I now think that it makes sense to merge this and the rest of the work can be done in the devel branch as soon as this gets to the devel branch. |
|
I am not happy with this PR. I ask that this not be merged at least until I understand it. |
|
ok I'm sorry everyone. merge it and i'll try it out. |
cachedout
added
the
Pending-Discussion
Recent changes to winrepo cause a CommandExecutionError to be raised when there is no winrepo cache. This catches these and gracefully fails the state. Resolves saltstack#33873.
|
Lint error should now be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to winrepo cause a CommandExecutionError to be raised
when there is no winrepo cache. This catches these and gracefully fails
the state.
Resolves #33873.