Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch CommandExecutionError in pkg states #34093

Merged
merged 2 commits into from
Jun 23, 2016

Conversation

terminalmage
Copy link
Contributor

Recent changes to winrepo cause a CommandExecutionError to be raised
when there is no winrepo cache. This catches these and gracefully fails
the state.

Resolves #33873.

@terminalmage
Copy link
Contributor Author

This likely needs a secondary fix, hold off on merging.

@ghost
Copy link

ghost commented Jun 18, 2016

I now think that it makes sense to merge this and the rest of the work can be done in the devel branch as soon as this gets to the devel branch.

@ghost
Copy link

ghost commented Jun 20, 2016

I am not happy with this PR. I ask that this not be merged at least until I understand it.

@ghost
Copy link

ghost commented Jun 20, 2016

ok I'm sorry everyone. merge it and i'll try it out.

@cachedout
Copy link
Contributor

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jun 21, 2016
Recent changes to winrepo cause a CommandExecutionError to be raised
when there is no winrepo cache. This catches these and gracefully fails
the state.

Resolves saltstack#33873.
@terminalmage
Copy link
Contributor Author

Lint error should now be resolved.

@cachedout cachedout merged commit 9296295 into saltstack:2015.8 Jun 23, 2016
@terminalmage terminalmage deleted the issue33873 branch July 7, 2016 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants