Fixes to git module & state module related to identity file #34110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alt://files/identity, if that file exists outside of the default base environment the file won't be accessible so we need to include the saltenv.
|
Thanks, @garethgreenaway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes to git module & state module related to using an identity file from a Salt URL.
What issues does this PR fix or reference?
N/A
Previous Behavior
If you specified an identity file via a Salt URL, eg. salt://files/identity and if that file is in a different environment than the default
basethen the file can't be found.New Behavior
New behavior, adding the ability to specify the saltenv for those functions where it makes sense. The functions in the state module that use an identify file the environment is passed along where applicable.
Tests written?
/No