Automated signing fixes for Ubuntu 16.04, 14.04, 12.04 #34406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meggiebot David wanted to make sure this was in before 2016.3.2 |
| use_passphrase=False, | ||
| gnupghome='/etc/salt/gpgkeys', | ||
| runas='root'): | ||
| def make_repo(repodir, keyid=None, env=None, use_passphrase=False, gnupghome='/etc/salt/gpgkeys', runas='root'): |
There was a problem hiding this comment.
Please adhere to the style guide reference regarding our preference for vertical layout: https://docs.saltstack.com/en/latest/topics/development/conventions/style.html#vertical-is-better
There was a problem hiding this comment.
Will do so in future, pylint didn't pill it up so missed it in rush to get in before vacation and tagging deadline.
cachedout
added
the
Pending-Discussion
|
@twangboy it's in now, will be in for 3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes package adn respository signing for Ubuntu 16.04
What issues does this PR fix or reference?
Fixes associated with vmware-archive/salt-pack#107
Previous Behavior
Automated package,repository signing failed on Ubuntu 16.04 due to use gpg v2.1
New Behavior
Automated package,repository signing now works on Ubuntu 16.04
Tests written?
No, signing packages and repository sufficient
Please review Salt's Contributing Guide for best practices.