Check for non-existant keys when updating PagerDuty escalation policies #34705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this allows repeat_enabled and num_loops to be passed to
pagerduty_escalation_policy.present.
Following the existing code, perhaps I should have done something like
this:
objects_differ = '{0} {1} {2}'.format(k, v, '')
But I don't see the value of objects_differ used as a string, only as
as a bool... so I set it as a bool.
By the way, salt/modules/pagerduty_util.py doesn't return 'changes'..
I'll open a seperate issue for that.
|
@bruce-lyft review please |
|
@cmclaughlin Did you want @bruce-lyft to look at this first or are we OK to get this in? |
|
@cachedout All good to merge... assuming the failed tests are OK. I just copied @bruce-lyft for review since he was the original author. |
|
lgtm. thanks for the ping |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jul 20, 2016
* upstream/develop: Comment out localclient in vdadm runner Check for non-existant keys when updating PagerDuty escalation policies (saltstack#34705) Remove iteritems() references from unit/transport/*.py files Remove iteritems() references from unit/modules/*.py Remove iteritems() references from integration tests Add jid=req handling for mysql returner. It should also store the return jid into the jid list table. Updates man pages (saltstack#34756) Remove unnedeed config test (saltstack#34751) Disable test Update azure lib dep to match the one in cloud.clouds.msazure add directives example to ldap3.modify Add cli examples for ldap3 module ipset.long_range doesn't need a docstring Minor. Fixed CR finding. Regex support in publisher ACL rules. Loop over updated keys in non recursive update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows repeat_enabled and num_loops to be passed to pagerduty_escalation_policy.present. Those fields are supported by the PagerDuty UI, but weren't supported by the pagerduty_escalation_policy state until now.
Previous Behavior
Trying to pass those fields in would cause an exception.
New Behavior
Sets those fields on new/update escalation polcies.
Tests written?
No
Following the existing code, perhaps I should have done something like
this:
But I don't see the value of objects_differ used as a string, only as
as a bool... so I set it as a bool.
By the way, salt/modules/pagerduty_util.py doesn't return 'changes'..
I'll open a separate issue for that.