salt/grains/core.py: restore bsd_cpudata grains update on FreeBSD; fi… #34771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xes 33608 After addressing saltstack#29882 in de56617 the call for grains.update(_bsd_cpudata(grains)) was omitted for FreeBSD and only called on NetBSD and OpenBSD.
|
Looks like #34382 is the same issue. |
|
I completely spaced that this was add at the bottom of the code block by another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After addressing #29882 in de56617 the call for grains.update(_bsd_cpudata(grains)) was omitted for FreeBSD and only called on NetBSD and OpenBSD.
What issues does this PR fix or reference?
#33608
Previous Behavior
grains.update skipped
New Behavior
grains.update called
Tests written?
No. Testing by the submitter noted in the issue and patched for the FreeBSD port in freebsd/freebsd-ports@0214514. I'd like to get that in 2016.3.2 so we can remove patching the port.