Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the thin does not match, then redeploy, don't error #34831

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

thatch45
Copy link
Contributor

What does this PR do?

@plastikos is there any reason not to do this? If the thin is bad we can just redeploy right?

What issues does this PR fix or reference?

#34509

Previous Behavior

Threw an error

New Behavior

Silently recovers

@s0undt3ch
Copy link
Collaborator

Could we enter in a non ending loop if something is way wrong and we just keep re-deploying?
Or, in this context, my comment is just absurd?

@thatch45
Copy link
Contributor Author

This has also been my concern, that if the tarball fails to deploy over and over again what are the implications? I don't think it should be an issue, since we very rarely have gotten reports of the checksum missmatch error. I think the optimal solution would be to add a notification to the user that it is not downloading properly when it retries

@plastikos
Copy link
Contributor

Seems reasonable to fold this into a re-deploy.

@thatch45
Copy link
Contributor Author

thatch45 commented Aug 9, 2016

Thanks @plastikos ! Also I think it is good that more people are aware of this change in case something goes awry. But I think this should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants