Stop multiple refreshes during call to pkg.list_upgrades #34898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
During a call to pkg.list_upgrades, pkg.latest_version gets called once for every package,
and pkg.latest_version calls refresh_db each time. I've passed refresh=False to pkg.latest
version, so it doesn't do any refreshing at all. pkg.list_upgrades is now solely reponsible
for refreshing or not refreshing.
What issues does this PR fix or reference?
#33620
Previous Behavior
One refresh per package and possibly another refresh too if param refresh to list_upgrades
isn't passed (defaults to True) or has value of True.
New Behavior
Maximally one refresh.
Tests written?
No