Only fail user lookup is the user parameter is required #35054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get() and check_inheritance() have an optional user parameter. While said parameter is optional, the functions in questions do not treat it as such, which at the very least breaks disable_inheritance() (used by win_dacl.disableinheritance) and enable_inheritance (used by win_dacl.enableinheritance), as those functions call check_inheritance() without the user parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes two functions that broke win_dacl.disableinheritance and win_dacl.enableinheritance.
Previous Behavior
win_dacl.disableinheritance and win_dacl.enableinheritance always failed, because check_inheritance() always returned false when called without the user parameter.
New Behavior
win_dacl.disableinheritance and win_dacl.enableinheritance succeed.
Tests written?
No
Summary
get() and check_inheritance() have an optional user parameter.
While said parameter is optional, the functions in questions
do not treat it as such, which at the very least breaks
disable_inheritance() (used by win_dacl.disableinheritance) and
enable_inheritance (used by win_dacl.enableinheritance), as those
functions call check_inheritance() without the user parameter.