Add append_minionid_config_dirs option #35178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this doesn't appear to affect caches for existing minions at all, this looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option to append the minion_id to some configuration directories, thereby namespacing them and preventing multiple minions or proxy minions from clobbering each others cache, pki, or extension module directories.
What issues does this PR fix or reference?
#34446
Previous Behavior
A minion and a proxy minion, or multiple proxy minions could overwrite each others cache directory contents.
New Behavior
When this option is set, cache directories are namespaced by minion_id.
Tests written?
No