Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pkgbuild.repo state recognize createrepo command return code #35197

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Make pkgbuild.repo state recognize createrepo command return code #35197

merged 1 commit into from
Aug 6, 2016

Conversation

vutny
Copy link
Contributor

@vutny vutny commented Aug 4, 2016

What does this PR do?

Makes pkgbuild.repo state function detect failures from execution of underlying command createrepo and return respective result.

Previous Behavior

pkgbuild.repo state always returns True unless test=True argument provided.

New Behavior

pkgbuild.repo state will return False if createrepo command exited with non-zero code.

Tests written?

No

@cachedout
Copy link
Contributor

Looks good. Thanks, @vutny

@cachedout cachedout merged commit d3f2ce2 into saltstack:2016.3 Aug 6, 2016
@vutny vutny deleted the pkgbuild-repo-failure-detection branch August 7, 2016 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vutny @cachedout