Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rabbitmq version detection using a package-agnostic version #35232

Merged
merged 2 commits into from
Aug 6, 2016
Merged

fix rabbitmq version detection using a package-agnostic version #35232

merged 2 commits into from
Aug 6, 2016

Conversation

theredcat
Copy link

@theredcat theredcat commented Aug 5, 2016

What does this PR do?

Fix rabbitmq version detection using a package-agnostic version. The package is not used anymore, so even if rabbitMQ wasn't installed with a package, the version can be determined. This is also useful on system where the package name isn't rabbitmq-server

I had to modify the >3.5.7 check-password code since it was raising an error when the password has to be changed where the old code return a bool

What issues does this PR fix or reference?

Fixes #34481
Fixes #35003
Fixes #33588

Previous Behavior

Use package version with hardcoded package name rabbitmq-server

New Behavior

Parse rabbitmqctl status stdout to determine the version

Tests written?

No

@cachedout cachedout merged commit 7302a8a into saltstack:2016.3 Aug 6, 2016
@cachedout
Copy link
Contributor

Excellent. Many thanks, @theredcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants