Fix freebsd netstat route on fbsd 10+ #35325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev009
force-pushed
the
fbsd-netstat-route
branch
from
bd44900
to
0d49dd3
Compare
|
Thanks, @kev009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
netstat seems to have changed in fbsd 10 and up. I don't have a fbsd 9 box to test, but the old function works on fbsd 8. Thanks to LLNW coworker Greg Phelps for discovery and fix proposal.
What issues does this PR fix or reference?
If we are on fbsd10, use the right column indexes
Previous Behavior
fbsd10+ will print a backtrace when running this function
New Behavior
fbsd10+ work with this function, fbsd8 continues to work
Tests written?
No