Add ignore_repo_failure option to suppress zypper's exit code 106 on … #35448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unavailable repos
|
@dincamihai Take an eyeball on this, please. |
|
@isbm it think this is fine. |
|
@dincamihai I think it is already explained for the user. As of tests I would open a separate PR, since we don't have tests for the whole installation thing. 😢 |
|
@isbm ok. |
|
@dincamihai Agreed. @cachedout your turn 😉 It has to be propagated up to |
|
LGTM. Thanks, @isbm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sync with the latest Zypper changes.
What issues does this PR fix or reference?
If Zypper finds at least one wrong repository (not available, empty etc) it stops everything, which is a correct behaviour. However, sometimes it is needed to "ignore" this kind of setup, as long as package is anyway available. For this
ignore_repo_failure=Falsehas been added. In order to let this start working,ignore_repo_failureneeds to be set toTrueexplicitly. The error message is still included for further references.Tests written?
No