fixes #34279 - disk cache ttl expiry #35453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theothergraham
force-pushed
the
fix_CacheDisk
branch
from
a2110d3
to
ae5b233
Compare
|
Awesome! Thanks, @theothergraham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the expiry of cache items loaded from disk in utils.cache.CacheDisk, and adds unit tests.
What issues does this PR fix or reference?
This PR fixes issue #34279
Previous Behavior
Pillar caches persisted to disk did not expire, and thus remained stale until the pillar cache file was removed.
New Behavior
Pillar caches persisted to disk now contain the key cache times, so that they can be reloaded and used to expire stale items.
Tests written?
Yes