Better systemd integration #35510
Merged
Better systemd integration #35510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2016
terminalmage
force-pushed
the
issue33516
branch
from
07db589
to
7c7d55d
Compare
|
You mentioned some DRY last night and I think there's some room for that but overall, thumbs up for sure. |
terminalmage
force-pushed
the
issue33516
branch
from
7c7d55d
to
5b5f19d
Compare
|
Lint is passing now, I made some changes to the tests because of the lint warning, so the tests should also pass. /me crosses fingers... |
|
Tests passing. |
|
W00t! this should finally resolve the long standing issue of the minion restarting itself, this is fantastic! |
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Aug 18, 2016
…d.booted This brings these tests inline with the changes made to salt.utils.systemd.booted in saltstack#35510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the use (where applicable) of
systemd-run --scopeto isolate package (and service) management commands from thesalt-miniondaemon's cgroup. This ensures that service restarts do not interrupt these commands.Additionally, it adds systemd notification support for the minion, syndic, and api.
Resolves #33516.
Resolves #33803.
NOTE: this will also require the removal of
KillMode=processfrom our unit files. Additionally, to fully support systemd notification, we need to change theType=line in the unit files for salt-minion, salt-syndic, and salt-api fromsimpletonotify. vmware-archive/salt-pack#131 has been opened to address this.