Check for Ign/Hit membership instead of == in aptpkg.refresh_db #36353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ubuntu 16 lists the first "column" of data differently than previous versions of Ubuntu. Instead of check for
Hit
orIgn
explicitly with==
, we should usein
instead to make sure display theHit
andIgn
returns.Ubuntu 16 looks like this:
Ubuntu 14 looks like this:
What issues does this PR fix or reference?
This should clear up the
integration.modules.pkg.PkgModuleTest.test_refresh_db
test failures on Ubuntu 16, as it should now be unlikely that a{}
will be returned if noGet
s are in theapt-get -q update
return:Tests written?
Yes - there is already a test written for this which found this change in behavior.
Please review Salt's Contributing Guide for best practices.