Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chocolatey #36508

Merged
merged 3 commits into from
Sep 23, 2016
Merged

Fix chocolatey #36508

merged 3 commits into from
Sep 23, 2016

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Updates documentation
Add's deprecation notice for Chocolatey function update, along with replacement function upgrade. Looks like they're bringing it in line with other package managers. Update will be used to update package indexes.
Fixes problem where software that installed/uninstalled correctly but required a reboot, or was already installed, etc... was being reported as failed.

What issues does this PR fix or reference?

#34099

Previous Behavior

Still using deprecated functions.
Installs requiring reboot were reporting back as failed (retcode = 3010)

New Behavior

Added upgrade function to replace deprecated update function
Returns success on the following retcodes for install/upgrade:

====  ===============================================
0     Successful
1641  The installer has initiated a restart. This message is indicative of a success.
3010  A restart is required to complete the install. This message is indicative of a success. This does not include installs where the ForceReboot action is run.
====  ===============================================

Returns success on the following retcodes for uninstall

====  ===============================================
0     Successful
1605  This action is only valid for products that are currently installed.
1614  The product is uninstalled.
1641  The installer has initiated a restart. This message is indicative of a success.
====  ===============================================

Tests written?

No

@cachedout cachedout merged commit 8104d5c into saltstack:2016.3 Sep 23, 2016

if __grains__['osrelease'] in ('XP', '2003Server'):
return (False, 'Cannot load module chocolatey: Chocolatey requires '
'Windows Vista or later')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twangboy it still works in 2003 (for how much longer though is a good question).

@twangboy twangboy deleted the fix_chocolatey branch August 21, 2017 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants