Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix thin argument for `lvm.lvcreate' #36641

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

fuzzy-id
Copy link

What does this PR do?

This adds thin to the list of parameters without arguments when calling lvcreate.

What issues does this PR fix or reference?

#36604

Tests written?

No

This fixes saltstack#36604. The `--thin' option of `lvcreate' does not accept a
further argument. I checked this for LVMs library version 1.02.77
(shipped in Ubuntu 14.04) and 1.02.110 (Ubuntu 16.04).
@cachedout cachedout merged commit 86dc3dc into saltstack:2014.7 Sep 29, 2016
@cachedout
Copy link
Contributor

@rallytime Could you please cherry-pick this into 2015.8 so it gets into the regular merge-forward cycle?

@fuzzy-id fuzzy-id deleted the fix-lvm-thin-argument branch September 29, 2016 09:26
@rallytime
Copy link
Contributor

Definitely - thanks for letting me know that this went in here! I haven't checked this old branch for a while. ;)

Please see #36678 and #36684. Now that those PRs are merged in, the normal merge-forward process will occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants